Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check mode for grafana role #125

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Fix check mode for grafana role #125

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1738e06
Register dashboards lists vars before removing not present dashboards…
Boschung-Mecatronic-AG-Infrastructure Nov 23, 2023
9d110d5
Implement when not ansible_check_mode condition
Boschung-Mecatronic-AG-Infrastructure Nov 23, 2023
9f5eaf2
Merge branch 'main' into fix-check-mode-role-grafana
ishanjainn Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions roles/grafana/tasks/dashboards.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,14 +123,18 @@
become: true
register: __dashboards_copied
notify: "provisioned dashboards changed"
when: not ansible_check_mode

- name: "Register present and copied dashboards list"
ansible.builtin.set_fact:
__dashboards_present_list: "{{ __dashboards_present | json_query('files[*].path') | default([]) }}"
__dashboards_copied_list: "{{ __dashboards_copied | json_query('results[*].dest') | default([]) }}"
when: not ansible_check_mode

- name: "Remove dashboards not present on deployer machine (synchronize)"
ansible.builtin.file:
path: "{{ item }}"
state: absent
loop: "{{ __dashboards_present_list | difference(__dashboards_copied_list) }}"
become: true
when: grafana_provisioning_synced
vars:
__dashboards_present_list: "{{ __dashboards_present | json_query('files[*].path') | default([]) }}"
__dashboards_copied_list: "{{ __dashboards_copied | json_query('results[*].dest') | default([]) }}"
when: grafana_provisioning_synced and not ansible_check_mode