[synthetic-monitoring-agent] fix deployment not starting on update/auto-scaling #2994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of the agent does not seem to allow for concurrency.
Thus scaling the deployment - either on helm-upgrade or auto-scaling - will result in the new PODs to never become ready!
So any helm-upgrade will run into a timeout and then abort.
In the logs you'll find the following messages (if debug is enabled):
With emphasis on:
response: probe already exists
To fix that, I changed the
Deployment
to aStatefulSet
, as k8s ensures, that the old POD is killed/deleted before spawning the new one.I also removed all the autoscaling-resources, as they're not useful anyway.
And of course, I also successfully tested the changes on one of our clusters.