Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synthetic-monitoring-agent] fix deployment not starting on update/auto-scaling #2994

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/lgtm-distributed/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,4 @@ Umbrella chart for a distributed Loki, Grafana, Tempo and Mimir stack
| tempo.ingester.replicas | int | `1` | |

----------------------------------------------
Autogenerated from chart metadata using [helm-docs v1.8.1](https://github.com/norwoodj/helm-docs/releases/v1.8.1)
Autogenerated from chart metadata using [helm-docs v1.13.0](https://github.com/norwoodj/helm-docs/releases/v1.13.0)
4 changes: 2 additions & 2 deletions charts/loki-distributed/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ kubectl delete statefulset RELEASE_NAME-loki-distributed-querier -n LOKI_NAMESPA
| compactor.livenessProbe | object | `{}` | liveness probe settings for ingester pods. If empty use `loki.livenessProbe` |
| compactor.nodeSelector | object | `{}` | Node selector for compactor pods |
| compactor.persistence.annotations | object | `{}` | Annotations for compactor PVCs |
| compactor.persistence.claims | list | `[{"name":"data","size":"10Gi","storageClass":null}]` | List of the compactor PVCs @notationType -- list |
| compactor.persistence.claims | list | | List of the compactor PVCs |
| compactor.persistence.enableStatefulSetAutoDeletePVC | bool | `false` | Enable StatefulSetAutoDeletePVC feature |
| compactor.persistence.enabled | bool | `false` | Enable creating PVCs for the compactor |
| compactor.persistence.size | string | `"10Gi"` | Size of persistent disk |
Expand Down Expand Up @@ -300,7 +300,7 @@ kubectl delete statefulset RELEASE_NAME-loki-distributed-querier -n LOKI_NAMESPA
| ingester.maxSurge | int | `0` | Max Surge for ingester pods |
| ingester.maxUnavailable | string | `nil` | Pod Disruption Budget maxUnavailable |
| ingester.nodeSelector | object | `{}` | Node selector for ingester pods |
| ingester.persistence.claims | list | `[{"name":"data","size":"10Gi","storageClass":null}]` | List of the ingester PVCs @notationType -- list |
| ingester.persistence.claims | list | | List of the ingester PVCs |
| ingester.persistence.enableStatefulSetAutoDeletePVC | bool | `false` | Enable StatefulSetAutoDeletePVC feature |
| ingester.persistence.enabled | bool | `false` | Enable creating PVCs which is required when using boltdb-shipper |
| ingester.persistence.inMemory | bool | `false` | Use emptyDir with ramdisk for storage. **Please note that all data in ingester will be lost on pod restart** |
Expand Down
2 changes: 1 addition & 1 deletion charts/synthetic-monitoring-agent/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ name: synthetic-monitoring-agent
sources:
- https://github.com/grafana/synthetic-monitoring-agent
type: application
version: 0.2.0
version: 0.3.0
10 changes: 2 additions & 8 deletions charts/synthetic-monitoring-agent/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# synthetic-monitoring-agent

![Version: 0.2.0](https://img.shields.io/badge/Version-0.2.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.9.3-0-gcd7aadd](https://img.shields.io/badge/AppVersion-v0.9.3--0--gcd7aadd-informational?style=flat-square)
![Version: 0.3.0](https://img.shields.io/badge/Version-0.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v0.9.3-0-gcd7aadd](https://img.shields.io/badge/AppVersion-v0.9.3--0--gcd7aadd-informational?style=flat-square)

Grafana's Synthetic Monitoring application. The agent provides probe functionality and executes network checks for monitoring remote targets.

Expand Down Expand Up @@ -32,11 +32,6 @@ Kubernetes: `^1.16.0-0`
| agent.debug | bool | `false` | Enable / disable debug logging on the agent. |
| agent.enableDisconnect | bool | `false` | Enable / disable the HTTP /disconnect endpoint |
| agent.verbose | bool | `false` | Enable / disable verbose logging on the agent. |
| autoscaling.enabled | bool | `false` | Enable autoscaling |
| autoscaling.maxReplicas | int | `3` | Maximum autoscaling replicas |
| autoscaling.minReplicas | int | `1` | Minimum autoscaling replicas |
| autoscaling.targetCPUUtilizationPercentage | int | `60` | Target CPU utilisation percentage |
| autoscaling.targetMemoryUtilizationPercentage | string | `nil` | Target memory utilisation percentage |
| extraObjects | list | `[]` | Add dynamic manifests via values: |
| fullnameOverride | string | `""` | Override the fullname of the chart. |
| hostAliases | list | `[]` | hostAliases to add |
Expand All @@ -52,7 +47,6 @@ Kubernetes: `^1.16.0-0`
| podLabels | object | `{}` | Labels to add to each pod. |
| podSecurityContext | object | `{"fsGroup":65534}` | Security context on the Pod level. |
| readinessProbe | object | `{"httpGet":{"path":"/ready","port":"http"}}` | Readiness probe for the agent |
| replicaCount | int | `1` | Number of replicas to use; ignored if `autoscaling.enabled` is set to `true`. |
| resources | object | `{}` | Default resources to apply. |
| securityContext | object | `{"capabilities":{"drop":["ALL"]},"readOnlyRootFilesystem":true,"runAsNonRoot":true,"runAsUser":65534}` | Security context for the container level. |
| service.annotations | object | `{}` | Annotations for the service |
Expand All @@ -75,4 +69,4 @@ Kubernetes: `^1.16.0-0`
| tolerations | list | `[]` | List of node taints to tolerate. |

----------------------------------------------
Autogenerated from chart metadata using [helm-docs v1.8.1](https://github.com/norwoodj/helm-docs/releases/v1.8.1)
Autogenerated from chart metadata using [helm-docs v1.13.0](https://github.com/norwoodj/helm-docs/releases/v1.13.0)
28 changes: 0 additions & 28 deletions charts/synthetic-monitoring-agent/templates/hpa.yaml

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
apiVersion: apps/v1
kind: Deployment
kind: StatefulSet
metadata:
name: {{ include "synthetic-monitoring-agent.fullname" . }}
labels:
{{- include "synthetic-monitoring-agent.labels" . | nindent 4 }}
spec:
minReadySeconds: 10
{{- if not .Values.autoscaling.enabled }}
replicas: {{ .Values.replicaCount }}
{{- end }}
replicas: 1
serviceName: {{ include "synthetic-monitoring-agent.fullname" . }}-headless
selector:
matchLabels:
{{- include "synthetic-monitoring-agent.selectorLabels" . | nindent 6 }}
Expand Down
15 changes: 0 additions & 15 deletions charts/synthetic-monitoring-agent/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ agent:
# -- Enable / disable verbose logging on the agent.
verbose: false

# -- Number of replicas to use; ignored if `autoscaling.enabled` is set to `true`.
replicaCount: 1

image:
# -- Base registry to pull the container image from.
registry: docker.io
Expand Down Expand Up @@ -72,18 +69,6 @@ resources:
# cpu: 200m
# memory: 512Mi

autoscaling:
# -- Enable autoscaling
enabled: false
# -- Minimum autoscaling replicas
minReplicas: 1
# -- Maximum autoscaling replicas
maxReplicas: 3
# -- Target CPU utilisation percentage
targetCPUUtilizationPercentage: 60
# -- Target memory utilisation percentage
targetMemoryUtilizationPercentage:

# -- Liveness probe for the agent
livenessProbe:
httpGet:
Expand Down