[tempo-distributed] fixing imagePullSecrets for enterprise components #3054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-simonovski
requested review from
mapno,
swartz-k,
BitProcessor and
faustodavid
as code owners
zanhsieh
changed the title
jordan-simonovski
force-pushed
the
fix-pullsecrets-templating
branch
from
20c4081
to
19becf2
Compare
Signed-off-by: Jordan Simonovski <[email protected]>
The config overrides from the values.yml need to be added to the README.md to ensure up-to-date documentation for charts. Signed-off-by: Jordan Simonovski <[email protected]>
Signed-off-by: Jordan Simonovski <[email protected]>
Signed-off-by: Jordan Simonovski <[email protected]>
jordan-simonovski
force-pushed
the
fix-pullsecrets-templating
branch
from
b9bdae2
to
d739d7e
Compare
zalegrala
reviewed
Apr 17, 2024
Adding standardised imagepullsecrets support to tokengenJob Signed-off-by: Jordan Simonovski <[email protected]>
|
This looks good to me. We need a version bump again for the PR that went in before this one. |
Signed-off-by: Jordan Simonovski <[email protected]>
…for future UID change Signed-off-by: Zach Leslie <[email protected]>
Signed-off-by: Jordan Simonovski <[email protected]>
Signed-off-by: Jordan Simonovski <[email protected]>
Signed-off-by: Jordan Simonovski <[email protected]>
Signed-off-by: Jordan Simonovski <[email protected]>
zalegrala
approved these changes
Apr 23, 2024
joe-elliott
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into the following issue when trying to deploy GET via ArgoCD:
After some debugging, I found some differences in the way that the
pullSecretsare derived in theadminApiand theenterpriseGatewaywhich I've now standardised to fix up some of the complexity when configuring this.