Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] fixing imagePullSecrets for enterprise components #3054

Merged
merged 13 commits into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/tempo-distributed/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: tempo-distributed
description: Grafana Tempo in MicroService mode
type: application
version: 1.9.3
version: 1.9.4
appVersion: 2.4.1
engine: gotpl
home: https://grafana.com/docs/tempo/latest/
Expand Down
14 changes: 13 additions & 1 deletion charts/tempo-distributed/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# tempo-distributed

![Version: 1.9.3](https://img.shields.io/badge/Version-1.9.3-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.4.1](https://img.shields.io/badge/AppVersion-2.4.1-informational?style=flat-square)
![Version: 1.9.4](https://img.shields.io/badge/Version-1.9.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 2.4.1](https://img.shields.io/badge/AppVersion-2.4.1-informational?style=flat-square)

Grafana Tempo in MicroService mode

Expand Down Expand Up @@ -223,6 +223,10 @@ The memcached default args are removed and should be provided manually. The sett
| adminApi.extraVolumeMounts | list | `[]` | |
| adminApi.extraVolumes | list | `[]` | |
| adminApi.hostAliases | list | `[]` | hostAliases to add |
| adminApi.image.pullSecrets | list | `[]` | Optional list of imagePullSecrets. Overrides `tempo.image.pullSecrets` |
| adminApi.image.registry | string | `nil` | The Docker registry for the adminApi image. Overrides `tempo.image.registry` |
| adminApi.image.repository | string | `nil` | Docker image repository for the adminApi image. Overrides `tempo.image.repository` |
| adminApi.image.tag | string | `nil` | Docker image tag for the adminApi image. Overrides `tempo.image.tag` |
| adminApi.initContainers | list | `[]` | |
| adminApi.nodeSelector | object | `{}` | |
| adminApi.persistence.subPath | string | `nil` | |
Expand Down Expand Up @@ -369,6 +373,10 @@ The memcached default args are removed and should be provided manually. The sett
| enterpriseGateway.extraVolumeMounts | list | `[]` | |
| enterpriseGateway.extraVolumes | list | `[]` | |
| enterpriseGateway.hostAliases | list | `[]` | hostAliases to add |
| enterpriseGateway.image.pullSecrets | list | `[]` | Optional list of imagePullSecrets. Overrides `tempo.image.pullSecrets` |
| enterpriseGateway.image.registry | string | `nil` | The Docker registry for the enterpriseGateway image. Overrides `tempo.image.registry` |
| enterpriseGateway.image.repository | string | `nil` | Docker image repository for the enterpriseGateway image. Overrides `tempo.image.repository` |
| enterpriseGateway.image.tag | string | `nil` | Docker image tag for the enterpriseGateway image. Overrides `tempo.image.tag` |
| enterpriseGateway.ingress.annotations | object | `{}` | Annotations for the gateway ingress |
| enterpriseGateway.ingress.enabled | bool | `false` | Specifies whether an ingress for the gateway should be created |
| enterpriseGateway.ingress.hosts | list | `[{"host":"gateway.gem.example.com","paths":[{"path":"/"}]}]` | Hosts configuration for the gateway ingress |
Expand Down Expand Up @@ -777,6 +785,10 @@ The memcached default args are removed and should be provided manually. The sett
| tokengenJob.extraArgs | object | `{}` | |
| tokengenJob.extraEnvFrom | list | `[]` | |
| tokengenJob.hostAliases | list | `[]` | hostAliases to add |
| tokengenJob.image.pullSecrets | list | `[]` | Optional list of imagePullSecrets. Overrides `tempo.image.pullSecrets` |
| tokengenJob.image.registry | string | `nil` | The Docker registry for the tokengenJob image. Overrides `tempo.image.registry` |
| tokengenJob.image.repository | string | `nil` | Docker image repository for the tokengenJob image. Overrides `tempo.image.repository` |
| tokengenJob.image.tag | string | `nil` | Docker image tag for the tokengenJob image. Overrides `tempo.image.tag` |
| tokengenJob.initContainers | list | `[]` | |
| traces.jaeger.grpc.enabled | bool | `false` | Enable Tempo to ingest Jaeger GRPC traces |
| traces.jaeger.grpc.receiverConfig | object | `{}` | Jaeger GRPC receiver config |
Expand Down
7 changes: 7 additions & 0 deletions charts/tempo-distributed/templates/admin-api/_helpers.tpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{{/*
adminApi imagePullSecrets
*/}}
{{- define "tempo.adminApiImagePullSecrets" -}}
{{- $dict := dict "tempo" .Values.tempo.image "component" .Values.adminApi.image "global" .Values.global.image -}}
{{- include "tempo.imagePullSecrets" $dict -}}
{{- end }}
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,7 @@ spec:
{{- with .Values.adminApi.initContainers }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if .Values.tempo.image.pullSecrets }}
imagePullSecrets:
{{- range .Values.image.pullSecrets }}
- name: {{ . }}
{{- end }}
{{- end }}
{{- include "tempo.adminApiImagePullSecrets" . | nindent 6 -}}
{{- with .Values.adminApi.hostAliases }}
hostAliases:
{{- toYaml . | nindent 8 }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,11 @@ Return if ingress supports pathType.
{{- define "tempo.ingress.supportsPathType" -}}
{{- or (eq (include "tempo.ingress.isStable" .) "true") (and (eq (include "tempo.ingress.apiVersion" .) "networking.k8s.io/v1beta1") (semverCompare ">= 1.18-0" .Capabilities.KubeVersion.Version)) -}}
{{- end -}}

{{/*
enterpriseGateway imagePullSecrets
*/}}
{{- define "tempo.enterpriseGatewayImagePullSecrets" -}}
{{- $dict := dict "tempo" .Values.tempo.image "component" .Values.enterpriseGateway.image "global" .Values.global.image -}}
{{- include "tempo.imagePullSecrets" $dict -}}
{{- end }}
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,7 @@ spec:
{{- toYaml .Values.enterpriseGateway.securityContext | nindent 8 }}
initContainers:
{{- toYaml .Values.enterpriseGateway.initContainers | nindent 8 }}
{{- if .Values.tempo.image.pullSecrets }}
imagePullSecrets:
{{- range .Values.image.pullSecrets }}
- name: {{ . }}
{{- end }}
{{- end }}
{{- include "tempo.enterpriseGatewayImagePullSecrets" . | nindent 6 -}}
{{- with .Values.enterpriseGateway.hostAliases }}
hostAliases:
{{- toYaml . | nindent 8 }}
Expand Down
7 changes: 7 additions & 0 deletions charts/tempo-distributed/templates/tokengen/__helpers.tpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{{/*
tokengen-job imagePullSecrets
*/}}
{{- define "tempo.tokengenJobImagePullSecrets" -}}
{{- $dict := dict "tempo" .Values.tempo.image "component" .Values.tokengenJob.image "global" .Values.global.image -}}
{{- include "tempo.imagePullSecrets" $dict -}}
{{- end }}
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,7 @@ spec:
{{- end }}
securityContext:
{{- toYaml .Values.tokengenJob.securityContext | nindent 8 }}
{{- if .Values.tempo.image.pullSecrets }}
imagePullSecrets:
{{- range .Values.tempo.image.pullSecrets }}
- name: {{ . }}
{{- end }}
{{- end }}
{{- include "tempo.tokengenJobImagePullSecrets" . | nindent 6 -}}
{{- with .Values.tokengenJob.hostAliases }}
hostAliases:
{{- toYaml . | nindent 8 }}
Expand Down
29 changes: 29 additions & 0 deletions charts/tempo-distributed/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1902,6 +1902,15 @@ tokengenJob:
env: []
extraEnvFrom: []
annotations: {}
image:
# -- The Docker registry for the tokengenJob image. Overrides `tempo.image.registry`
registry: null
# -- Optional list of imagePullSecrets. Overrides `tempo.image.pullSecrets`
pullSecrets: []
# -- Docker image repository for the tokengenJob image. Overrides `tempo.image.repository`
repository: null
# -- Docker image tag for the tokengenJob image. Overrides `tempo.image.tag`
tag: null
initContainers: []
# -- The SecurityContext for tokenjobgen containers
containerSecurityContext:
Expand All @@ -1922,6 +1931,16 @@ adminApi:
annotations: {}
labels: {}

image:
# -- The Docker registry for the adminApi image. Overrides `tempo.image.registry`
registry: null
# -- Optional list of imagePullSecrets. Overrides `tempo.image.pullSecrets`
pullSecrets: []
# -- Docker image repository for the adminApi image. Overrides `tempo.image.repository`
repository: null
# -- Docker image tag for the adminApi image. Overrides `tempo.image.tag`
tag: null

initContainers: []

strategy:
Expand Down Expand Up @@ -2009,6 +2028,16 @@ enterpriseGateway:
# hostnames:
# - domain.tld

image:
# -- The Docker registry for the enterpriseGateway image. Overrides `tempo.image.registry`
registry: null
# -- Optional list of imagePullSecrets. Overrides `tempo.image.pullSecrets`
pullSecrets: []
# -- Docker image repository for the enterpriseGateway image. Overrides `tempo.image.repository`
repository: null
# -- Docker image tag for the enterpriseGateway image. Overrides `tempo.image.tag`
tag: null

annotations: {}
service:
# -- Port of the enterprise gateway service; if left undefined, the service will listen on the same port as the pod
Expand Down
Loading