-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing permissions in update-helm-repo workflow #3383
Conversation
Signed-off-by: Vladimir Varankin <[email protected]>
Signed-off-by: Vladimir Varankin <[email protected]>
@@ -145,7 +146,7 @@ jobs: | |||
- name: Install Helm | |||
uses: azure/setup-helm@v4 | |||
with: | |||
version: v3.5.2 | |||
version: v3.16.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that helm push
was introduced in 3.7.0
, which was release in 2021.
With 3.5.2 the workflow fails with:
The workflow fails with "Error: unknown command "push" for helm"
I propose we update to the latest release, which is 3.16, as of today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stamp.
Note that we also need the repo's admin to add Right now, with the fixes from this PR, the CI job fails when it pushes the OCI package:
I've found this explanation of the problem. |
This is the fixup for #3366
The changes in #3366 added an explicit list of
permissions
, the workflow intents to use. It seems that this broke the release of Helm charts in Mimir. The "Push release tag on origin" now fails with the following:(refer to this failed build)
If I understand it right, even though we add all necessary permissions in the repo's "Workflow permissions" settings, the
permissions
explicitly defined in workflow's YAML override those (refer to github docs). And since the workflow doesn't list thecontents: write
, the action, that executes the workflow cannot push the tag. This PR fixes that.