Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing permissions in update-helm-repo workflow #3383

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Add missing permissions in update-helm-repo workflow #3383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c360211
workflows: add missing permissions
narqo Oct 29, 2024
226cf91
update helm to 3.16 latest
narqo Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/update-helm-repo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ jobs:
needs: [setup]
runs-on: ubuntu-latest
permissions:
packages: write
contents: write # to push chart release, create release, and push tags to github
packages: write # to push package to ghcr
env:
github_app_id: ${{ secrets.github_app_id }}
if: needs.setup.outputs.changed == 'true'
Expand Down Expand Up @@ -145,7 +146,7 @@ jobs:
- name: Install Helm
uses: azure/setup-helm@v4
with:
version: v3.5.2
version: v3.16.2
Copy link
Contributor Author

@narqo narqo Oct 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that helm push was introduced in 3.7.0, which was release in 2021.

With 3.5.2 the workflow fails with:

The workflow fails with "Error: unknown command "push" for helm"

I propose we update to the latest release, which is 3.16, as of today.


- name: Parse Chart.yaml
id: parse-chart
Expand Down
Loading