Chore: Migrate #99348 from grafana/grafana

src/helpers/MetricDataSourceHelper.test.ts

@@ -40,5 +40,21 @@ describe('MetricDatasourceHelper', () => {
       const result = await metricDatasourceHelper.isNativeHistogram('non_histogram_metric');
       expect(result).toBe(false);
     });
+
+    it('should return false if metric is a classic histogram', async () => {
+      const result = await metricDatasourceHelper.isNativeHistogram('test_metric_bucket');
+      expect(result).toBe(false);
+    });
+
+    it('should return true if metric is a native histogram and has metadata but does not have a classic histogram to compare to', async () => {
+      metricDatasourceHelper._metricsMetadata = {
+        solo_native_histogram: {
+          type: 'histogram',
+          help: 'test',
+        },
+      };
+      const result = await metricDatasourceHelper.isNativeHistogram('solo_native_histogram');
+      expect(result).toBe(true);
+    });
   });
 });

src/helpers/MetricDatasourceHelper.ts

@@ -56,7 +56,8 @@ export class MetricDatasourceHelper {
     return this._datasource;
   }
 
-  _metricsMetadata?: Promise<PromMetricsMetadata | undefined>;
+  // store metadata in a more easily accessible form
+  _metricsMetadata?: PromMetricsMetadata | undefined;
 
   private async _getMetricsMetadata() {
     const ds = await this.getDatasource();
@@ -77,7 +78,7 @@ export class MetricDatasourceHelper {
       return undefined;
     }
     if (!this._metricsMetadata) {
-      this._metricsMetadata = this._getMetricsMetadata();
+      this._metricsMetadata = await this._getMetricsMetadata();
     }
 
     const metadata = await this._metricsMetadata;
@@ -90,9 +91,12 @@ export class MetricDatasourceHelper {
   public listNativeHistograms() {
     return this._nativeHistograms;
   }
+
   /**
-   * Identify native histograms by querying classic histograms and all metrics,
+   * Identify native histograms by 2 strategies.
+   * 1. querying classic histograms and all metrics,
    * then comparing the results and build the collection of native histograms.
+   * 2. querying all metrics and checking if the metric is a histogram type and dies not have the bucket suffix.
    *
    * classic histogram = test_metric_bucket
    * native histogram = test_metric
@@ -109,6 +113,11 @@ export class MetricDatasourceHelper {
         this._classicHistograms[m.text] = 1;
       });
 
+      if (!this._metricsMetadata && !ds.languageProvider.metricsMetadata) {
+        await ds.languageProvider.loadMetricsMetadata();
+        this._metricsMetadata = ds.languageProvider.metricsMetadata;
+      }
+
       allMetrics.forEach((m) => {
         if (this.isNativeHistogram(m.text)) {
           // Build the collection of native histograms.
@@ -119,19 +128,33 @@ export class MetricDatasourceHelper {
   }
 
   /**
-   *
-   * If a metric name + _bucket exists in the classic histograms, then it is a native histogram
+   * Identify native histograms by 2 strategies.
+   * 1. querying classic histograms and all metrics,
+   * then comparing the results and build the collection of native histograms.
+   * 2. querying all metrics and checking if the metric is a histogram type and dies not have the bucket suffix.
    *
    * classic histogram = test_metric_bucket
    * native histogram = test_metric
+   *
    * @param metric
-   * @returns
+   * @returns boolean
    */
   public isNativeHistogram(metric: string): boolean {
     if (!metric) {
       return false;
     }
 
+    // check when fully migrated, we only have metadata, and there are no more classic histograms
+    const metadata = this._metricsMetadata;
+    // suffix is not 'bucket' and type is histogram
+    const suffix: string = metric.split('_').pop() ?? '';
+    // the string is not equal to bucket
+    const notClassic = suffix !== 'bucket';
+    if (metadata?.[metric]?.type === 'histogram' && notClassic) {
+      return true;
+    }
+
+    // check for comparison when there is overlap between native and classic histograms
     if (this._classicHistograms[`${metric}_bucket`]) {
       return true;
     }