Makes singleton resources finding with an id work #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 1.5.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jkeen
pushed a commit
to jkeen/graphiti
that referenced
this pull request
Mar 27, 2024
Address edge case where ResourceName.find({id: id}) would error if controller was set up as a show action
jkeen
pushed a commit
to jkeen/graphiti
that referenced
this pull request
Mar 27, 2024
## [1.5.3](graphiti-api/graphiti@v1.5.2...v1.5.3) (2024-03-18) ### Bug Fixes * leverage ruby-2.7 parameter forwarding ([graphiti-api#431](graphiti-api#431)) ([ae09a46](graphiti-api@ae09a46)) * prevent :id stripping when :id not in path ([graphiti-api#447](graphiti-api#447)) ([e1dd811](graphiti-api@e1dd811))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a resource, setting a primary endpoint, and then using
ResourceName.find({id: id})doesn't work if the controller is set up as ashowaction.You get
ResourceName cannot be called directly from endpoint /api/v1/resource#show!This is why.
A workaround is to either go with
self.validate_endpoints = falseor change the action to be anindexaction, which bypasses the stripping of a would-be id.This PR changes the behavior to only strip the
idfrompathif the id is actually inpath!