-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: wip changes to integrate with sdk #872
Conversation
Signed-off-by: Tomás Migone <[email protected]>
chore: wip changes to integrate with sdk
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
- Coverage 92.71% 92.69% -0.02%
==========================================
Files 47 46 -1
Lines 2389 2369 -20
Branches 435 426 -9
==========================================
- Hits 2215 2196 -19
+ Misses 174 173 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this massive lift 💪
A few small comments but LGTM.
(I'm a bit scared of the merge conflicts we'll have on the tests for some open PRs, but I guess there'll never be an ideal time, better to merge this now and fix those as they appear)
Signed-off-by: Tomás Migone <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (sorry for the merge conflicts, I can re-approve when you fix them)
Signed-off-by: Tomás Migone <[email protected]>
…ge (#888) * chore: convert repo into a yarn workspaces monorepo Signed-off-by: Tomás Migone <[email protected]> * chore: add sdk Signed-off-by: Tomás Migone <[email protected]> * chore: fix cross reference dependencies and add readme Signed-off-by: Tomás Migone <[email protected]> * ci: fix setup action Signed-off-by: Tomás Migone <[email protected]> * ci: use yarn v4 Signed-off-by: Tomás Migone <[email protected]> * ci: add missing property to setup action Signed-off-by: Tomás Migone <[email protected]> * ci: add more missing properties Signed-off-by: Tomás Migone <[email protected]> * ci: refactor corepack enable Signed-off-by: Tomás Migone <[email protected]> * ci: run for all branches and prs Signed-off-by: Tomás Migone <[email protected]> * ci: fix coverage file path Signed-off-by: Tomás Migone <[email protected]> * ci: add workflow dispatch trigger Signed-off-by: Tomás Migone <[email protected]> * chore: trigger ci Signed-off-by: Tomás Migone <[email protected]> * chore: update README Signed-off-by: Tomás Migone <[email protected]> * test: fix failing tests Signed-off-by: Tomás Migone <[email protected]> * chore: minor nits Signed-off-by: Tomás Migone <[email protected]> * chore: fixup prettier config Signed-off-by: Tomás Migone <[email protected]> * chore: roll back prettier-plugin-solidity to old version to avoid reformatting Signed-off-by: Tomás Migone <[email protected]> * chore: bump packages versions and add publish ci action Signed-off-by: Tomás Migone <[email protected]> * docs: update readme with versioning and publishing instructions Signed-off-by: Tomás Migone <[email protected]> --------- Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
This PR is the integration with https://github.com/graphprotocol/sdk.
It's a gigantic PR to review... so here are the sanity checks I've been using to validate the changes:
yarn test
L1_NETWORK=localhost yarn test:e2e
hh console --network mainnet
and query some values likeawait g.l2.contracts.GraphToken.totalSupply()
Changes
@graphprotocol/sdk
for unit tests, e2e tests and hardhat tasks.graph.hardhat.yml
orgraph.arbitrum-hardhat.yml
) and an address book, and use same code/logic as e2e tests and migrate/deploy commands.cli
now "deprecated". No code fromcli/
should be used anywhere. Will remove in a followup PR once we finish migrating any useful command.GraphGovernance
contract