Use DeploymentId type from toolshed repo

[Jannis]

This drops the custom SubgraphDeploymentID type in favor of the DeploymentId type from the https://github.com/edgeandnode/toolshed repository, which we're working on making sort of a Graph standard utility library.

Saves a bunch of code and is one more isolated piece of #54.

[hopeyen]

lgtm, just need to pass the formatting check

[aasseman]

Looks great, though I didn't really look into what's going on with service/src/common/indexer_management/mod.rs.

[Jannis]

Looks great, though I didn't really look into what's going on with service/src/common/indexer_management/mod.rs.

@aasseman There's two main changes there:

1. There were a few issues between the deployments filter for cost models and what was returned (and merged with the global cost model).
2. I tried to strongly type the deployment field of the CostModel type and still make deserialization from the database work but gave up after two days (among other things, the special "global" deployment ID in the cost model table was annoying. So now there's three types:

• DbCostModel is an internal type and is what is returned by the db queries, with deployment IDs being String ("0x...").
• CostModel is the public type returned by the cost_models() and cost_model() functions; this never includes "global" as the deployment, so DeploymentId worked well here.
• GqlCostModel is a helper type to serialize deployments in cost models to IPFS hashes.

[hopeyen]

There were a few issues between the deployments filter for cost models and what was returned (and merged with the global cost model).

Could you describe what the issues were for the previous cost model responses? I read through the test cases and they seemed to match with my understanding of how it worked

So now there's three types

I can't seem to find GqlCostModel here or in toolshed, could you help me locate it 🤔 ?

[Jannis]

There were a few issues between the deployments filter for cost models and what was returned (and merged with the global cost model).

Could you describe what the issues were for the previous cost model responses? I read through the test cases and they seemed to match with my understanding of how it worked

One was that if you provided no deployments filter for cost_model(), it would return all existing cost models (including the "global" one, I think) without merging in the global model (https://github.com/graphops/indexer-service-rs/pull/63/files#diff-21ab5cb781d51883665196101d048fe83b746acdd69253df92bdedcfcf6cbba9L85).

It may be that that was the only one related to the database. Another was that the error handling around invalid deployment IDs passed in via GraphQL was a bit sketchy, and the conversion between IPFS hashes (required for the GraphQL API) and hex strings (required for the database) wasn't very robust. I tried to make those parts more obvious and robust.

So now there's three types

I can't seem to find GqlCostModel here or in toolshed, could you help me locate it 🤔 ?

@hopeyen Ooops, it's called GraphQlCostModel: https://github.com/graphops/indexer-service-rs/pull/63/files#diff-30f1dd4cff74e5decaff51bc44c6cea8ddc6f74813106dbe1c0fe609d5ca6b6bR19

[aasseman]

Looks great, though I didn't really look into what's going on with service/src/common/indexer_management/mod.rs.

@aasseman There's two main changes there:

1. There were a few issues between the deployments filter for cost models and what was returned (and merged with the global cost model).
2. I tried to strongly type the deployment field of the CostModel type and still make deserialization from the database work but gave up after two days (among other things, the special "global" deployment ID in the cost model table was annoying. So now there's three types:

• DbCostModel is an internal type and is what is returned by the db queries, with deployment IDs being String ("0x...").
• CostModel is the public type returned by the cost_models() and cost_model() functions; this never includes "global" as the deployment, so DeploymentId worked well here.
• GqlCostModel is a helper type to serialize deployments in cost models to IPFS hashes.

Thanks 🙏 !

[hopeyen]

thanks for the explanation. looks good!