Be explicit how to handle unknown request information #1151
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for graphql-spec-draft ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BoD
approved these changes
Mar 27, 2025
benjie
approved these changes
Mar 28, 2025
BoD
approved these changes
Apr 3, 2025
benjie
approved these changes
Apr 3, 2025
michaelstaib
approved these changes
Apr 3, 2025
benjie
added
the
✏️ Editorial
mjmahone
approved these changes
Apr 3, 2025
robrichard
approved these changes
Apr 3, 2025
PascalSenn
approved these changes
Apr 3, 2025
|
looks right - I'll tweak wording and then merge |
benjie
reviewed
Apr 3, 2025
| @@ -20,6 +20,10 @@ Given this information, the result of {ExecuteRequest(schema, document, | |||
| operationName, variableValues, initialValue)} produces the response, to be | |||
| formatted according to the Response section below. | |||
|
|
|||
| A GraphQL service must ignore unrecognized information in a request. This allows | |||
There was a problem hiding this comment.
This seems a little broad; arguably something inside the document (an unknown directive, a new syntactic symbol, fragment arguments) is in the request and could be unrecognized, and those should result in validation/parse errors rather than being ignored. Maybe we can use “additional” instead, such as “must ignore any additional unrecognised information” - that implies it’s outside of what’s already specified here?
There was a problem hiding this comment.
Makes sense to me 👍 . I know @leebyron wanted to make some wording changes, I'll defer to his decision.
benjie
reviewed
Apr 3, 2025
Co-authored-by: Benjie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are discussing adding a new request parameter for disabling error propagation, we'll need this. This should probably have been added 5 years ago but now is better than later. I think this is what most implementations are doing anyway.