Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit how to handle unknown request information #1151

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Be explicit how to handle unknown request information #1151

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a9f82f
Add a provision for new request parameters
martinbonnin Mar 27, 2025
5a93620
format
martinbonnin Mar 27, 2025
35ab338
Update Section 6 -- Execution.md
leebyron Apr 3, 2025
c133ab2
Update Section 6 -- Execution.md
leebyron Apr 3, 2025
64b5af3
Update spec/Section 6 -- Execution.md
martinbonnin Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions spec/Section 6 -- Execution.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ Given this information, the result of {ExecuteRequest(schema, document,
operationName, variableValues, initialValue)} produces the response, to be
formatted according to the Response section below.

A GraphQL service must ignore unrecognized information in a request. This allows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a little broad; arguably something inside the document (an unknown directive, a new syntactic symbol, fragment arguments) is in the request and could be unrecognized, and those should result in validation/parse errors rather than being ignored. Maybe we can use “additional” instead, such as “must ignore any additional unrecognised information” - that implies it’s outside of what’s already specified here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍 . I know @leebyron wanted to make some wording changes, I'll defer to his decision.

a service to remain resilient to changes in future versions of this
specification.

Note: GraphQL requests do not require any specific serialization format or
transport mechanism. Message serialization and transport mechanisms should be
chosen by the implementing service.
Expand Down
Loading