Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Clang build to include system headers and libclang #36309

Closed
wants to merge 1 commit into from

Conversation

jakule
Copy link
Contributor

@jakule jakule commented Jan 4, 2024

This commit updates the build command in Dockerfile-centos7 to install 'clang-resource-headers' and 'libclang'. These additions are needed by boring-rs library to build correctly. We're building it as a part of our FIPS build.

This commit updates the build command in Dockerfile-centos7 to install 'clang-resource-headers' and 'libclang'. These additions are needed by boring-rs library to build correctly. We're building it as a part of our FIPS build.
Copy link

github-actions bot commented Jan 4, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@jakule jakule added the no-changelog Indicates that a PR does not require a changelog entry label Jan 4, 2024
@jakule jakule changed the title Update Dockerfile-centos7 to install additional dev tools Update Clang build to include system headers and libclang Jan 4, 2024
Copy link
Contributor

@ibeckermayer ibeckermayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just merge this into #36280?

@jakule
Copy link
Contributor Author

jakule commented Jan 4, 2024

Should we just merge this into #36280?

IMO, we should make this first, update the assets image, and then merge #36280 to include the updated toolchain.

@reedloden
Copy link
Contributor

We're merging this into #36280.

@reedloden reedloden closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants