Add request.reason.mode to role conditions (proto only) #49256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopiczko
force-pushed
the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
from
f85ba50 to
4308e9a
Compare
|
🤖 Vercel preview here: https://docs-gj09phdxw-goteleport.vercel.app/docs |
kopiczko
force-pushed
the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
from
4308e9a to
85ed4e2
Compare
kopiczko
added
the
no-changelog
|
🤖 Vercel preview here: https://docs-iu8m740w9-goteleport.vercel.app/docs |
github-actions
bot
requested review from
bernardjkim,
hugoShaka,
marcoandredinis,
mmcallister,
ptgott,
r0mant,
tigrato,
xinding33 and
zmb3
kopiczko
requested review from
smallinsky
and removed request for
marcoandredinis,
tigrato,
mmcallister,
zmb3,
bernardjkim,
hugoShaka,
xinding33 and
ptgott
smallinsky
approved these changes
Nov 22, 2024
kopiczko
force-pushed
the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
2 times, most recently
from
52ad350 to
ee9ad8c
Compare
kopiczko
force-pushed
the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
from
ee9ad8c to
5dc5c11
Compare
|
🤖 Vercel preview here: https://docs-awft6j3dy-goteleport.vercel.app/docs |
|
🤖 Vercel preview here: https://docs-h07p6w45s-goteleport.vercel.app/docs |
kopiczko
force-pushed
the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
from
5dc5c11 to
a3c1ced
Compare
|
🤖 Vercel preview here: https://docs-hxpp0dsot-goteleport.vercel.app/docs |
kopiczko
force-pushed
the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
from
a3c1ced to
f31a96d
Compare
|
🤖 Vercel preview here: https://docs-g8dkf0qbj-goteleport.vercel.app/docs |
This changes the proto type (+validation) only to declutter the original PR #49124 The real changes are in - api/proto/teleport/legacy/types/types.proto - api/types/access_request.go - lib/auth/auth_with_roles.go - lib/auth/auth_with_roles_test.go The rest is all generated.
kopiczko
force-pushed
the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
from
f31a96d to
707dcfd
Compare
|
🤖 Vercel preview here: https://docs-niobmii1n-goteleport.vercel.app/docs |
kopiczko
deleted the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
kopiczko
restored the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
kopiczko
deleted the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
kopiczko
restored the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
kopiczko
deleted the
kopiczko/add-role.spec.allow.request.reason.required-proto-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #20164
This changes the proto type (+validation) only to declutter the original PR #49124
The real changes are in
api/proto/teleport/legacy/types/types.protoapi/types/access_request.goapi/types/role.golib/auth/auth_with_roles.golib/auth/auth_with_roles_test.goThe rest is all generated.
I also added support for custom GOBIN in in integrations/terraform/Makefile in this PR #49259