Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wait after spanner test client is disconnected #49531

Merged
merged 2 commits into from
Dec 3, 2024
Merged

wait after spanner test client is disconnected #49531

merged 2 commits into from
Dec 3, 2024

Conversation

GavinFrazar
Copy link
Contributor

@GavinFrazar GavinFrazar added the no-changelog Indicates that a PR does not require a changelog entry label Nov 28, 2024
@GavinFrazar GavinFrazar requested a review from greedy52 November 28, 2024 02:49
@github-actions github-actions bot requested a review from tigrato November 28, 2024 02:49
@github-actions github-actions bot added database-access Database access related issues and PRs size/sm labels Nov 28, 2024
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/fix-flaky-spanner-test branch from fb33d93 to 4ca4b58 Compare November 28, 2024 06:24
tigrato
tigrato reviewed Nov 28, 2024
View reviewed changes
lib/srv/db/spanner_test.go Outdated Show resolved Hide resolved
@GavinFrazar GavinFrazar force-pushed the gavinfrazar/fix-flaky-spanner-test branch from 6163b29 to 53f912c Compare December 3, 2024 03:15
tigrato
tigrato approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Much better now

@GavinFrazar GavinFrazar added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit 1c5acff Dec 3, 2024
40 checks passed
@GavinFrazar GavinFrazar deleted the gavinfrazar/fix-flaky-spanner-test branch December 3, 2024 18:29
@public-teleport-github-review-bot
Copy link

@GavinFrazar See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR
branch/v17 Create PR

This was referenced Dec 3, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greedy52 greedy52 greedy52 approved these changes

@tigrato tigrato tigrato approved these changes

Assignees
No one assigned
Labels
backport/branch/v15 backport/branch/v16 backport/branch/v17 database-access Database access related issues and PRs no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestAuditSpanner/access_denied flakiness
3 participants
@GavinFrazar @tigrato @greedy52