Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wait after spanner test client is disconnected #49531

Merged
merged 2 commits into from
Dec 3, 2024
Merged

wait after spanner test client is disconnected #49531

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ca4b58
wait after spanner test client is disconnected
GavinFrazar Nov 28, 2024
53f912c
watch client connection state in test
GavinFrazar Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/srv/db/spanner_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,10 @@ func TestAuditSpanner(t *testing.T) {
require.True(t, ok)
require.Equal(t, "googlesql", dbStart1.DatabaseName)

// the connection should start to shut down, but wait some time for that
// to happen before sending further RPCs so that the client will dial
// a new connection before sending another query RPC.
time.Sleep(500 * time.Millisecond)
GavinFrazar marked this conversation as resolved.
Show resolved Hide resolved
row, err = pingSpanner(ctx, clt, 42)
require.Error(t, err)
require.ErrorContains(t, err, "access to db denied")
Expand Down
Loading