Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch plant_nursery pattern to SVG [WIP] #2685

Closed
wants to merge 1 commit into from

Conversation

kocio-pl
Copy link
Collaborator

Related to #2045.

Warsaw, z17
Before
zpie0d0t
After
457lgxqg

@pnorman pnorman mentioned this pull request Jul 10, 2017
18 tasks
@imagico
Copy link
Collaborator

imagico commented Jul 10, 2017

Here the sample clearly shows an error.

The SVG contains a stroke-width:0.125 which does not belong there - this however is likely not the cause of the error.

My guess is that Mapnik kind of auto-offsets/auto-centers SVGs (which is insane for pattern images) - since the forest pattern symbols cross the edges on all sides there is no offset but with the other patterns there are.

@kocio-pl
Copy link
Collaborator Author

I hope we can fix it somehow, but until then I would drop this PR.

@imagico
Copy link
Collaborator

imagico commented Jul 11, 2017

From my point of view there are two ways to deal with that other than fixing Mapnik:

  • adjust the symbol offsets of the pattern so that the symbols cross all edges like in case of the forest pattern - this is always possible.
  • add an invisible geometry to the SVG that prevents Mapnik from messing with it.

@kocio-pl
Copy link
Collaborator Author

I don't know how to do it, but if you do, that would be great.

@kocio-pl kocio-pl changed the title Switch plant_nursery pattern to SVG Switch plant_nursery pattern to SVG [WIP] Jul 13, 2017
@imagico
Copy link
Collaborator

imagico commented Jul 14, 2017

I re-opened imagico/jsdotpattern#3 because of this.

@pnorman
Copy link
Collaborator

pnorman commented Jul 14, 2017

add an invisible geometry to the SVG that prevents Mapnik from messing with it.

That's what we've been doing in the past.

@kocio-pl
Copy link
Collaborator Author

As this code shows some problems and it looks like there's nothing new for a month to fix it, I'm closing this PR now.

@kocio-pl kocio-pl closed this Aug 11, 2017
@kocio-pl kocio-pl deleted the plant_nursery-svg branch August 11, 2017 17:52
@kocio-pl
Copy link
Collaborator Author

It looks like new script fixes the problem here too. It's just 128 px (we don't have to worry about 512 px limit), so I can create new PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants