-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch plant_nursery pattern to SVG [WIP] #2685
Conversation
Here the sample clearly shows an error. The SVG contains a My guess is that Mapnik kind of auto-offsets/auto-centers SVGs (which is insane for pattern images) - since the forest pattern symbols cross the edges on all sides there is no offset but with the other patterns there are. |
I hope we can fix it somehow, but until then I would drop this PR. |
From my point of view there are two ways to deal with that other than fixing Mapnik:
|
I don't know how to do it, but if you do, that would be great. |
I re-opened imagico/jsdotpattern#3 because of this. |
That's what we've been doing in the past. |
As this code shows some problems and it looks like there's nothing new for a month to fix it, I'm closing this PR now. |
It looks like new script fixes the problem here too. It's just 128 px (we don't have to worry about 512 px limit), so I can create new PR soon. |
Related to #2045.
Warsaw, z17
Before
After