Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering farmland earlier on midzoom #2722

Merged
merged 1 commit into from
Aug 8, 2017

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Aug 2, 2017

Related to #2654.

Start rendering farmlands on z8+ instead of z10+. I don't want to touch lowzoom yet (#2688), but when we start showing forests/woods on midzoom, we can also show the farmlands, because both are very popular and with color fading they enhance the background in a subtle way.

Full Poland extract (click to see unscaled images):
z8
poland-z8-farmland
z9 (converted to JPG to fit in the GitHub filesize limit)
poland-z9-farmland

@matthijsmelissen
Copy link
Collaborator

👍
What does this do to render times? Even a rough estimation is fine.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 2, 2017

I'm in a middle of system upgrade - HDD is just bad choice when dealing with country/continent/planet database, so I will try to measure it when new SSD take over.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 3, 2017

@rrzefox Could you update your map layer with this patch? And maybe even tell us what is the performance hit?

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 3, 2017

For OSM servers low+mid zoom levels (z0-z12) would be no big deal anyway, since they update them only when deploying new release.

@matthijsmelissen
Copy link
Collaborator

And whenever we are developing on these zoom levels, of course.

@matthijsmelissen
Copy link
Collaborator

Also the re-creation process already takes multiple hours, that amount shouldn't multiply.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 6, 2017

Single Poland exporting times (compared to master), database on SSD:

  • z8: 2:32 (2:45)
  • z9: 3:34 (3:22)

Looks like they are roughly the same.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Aug 7, 2017

Romania (click to see unscaled images):
z8
1r9b3bbw
z9
wpu75_qn

See also #2688 (comment) for low zoom rendering with farmlands.

@kocio-pl kocio-pl merged commit 7f7ff2a into gravitystorm:master Aug 8, 2017
@kocio-pl kocio-pl deleted the farmland-z8-up branch August 8, 2017 11:42
@rrzefox
Copy link

rrzefox commented Aug 11, 2017

@rrzefox Could you update your map layer with this patch? And maybe even tell us what is the performance hit?

Even though this has already been merged, I've now added that patch on my server.
I checked with a few rerendered tiles, and the rendering time more or less stays the same, there is no mayor performance hit.

@imagico
Copy link
Collaborator

imagico commented Aug 11, 2017

Independent of the question how this fits into the design of these zoom levels - which as indicated i don't get in general so i have not commented - it should be clear that showing wood and farmland earlier than all other landcovers makes the style significantly more euro-centric than it already is. Showing wood/forest earlier than all other landcovers is questionable but defensible considering how distinct and globally widespread woodland is and that it often continuously covers larger areas. But i don't see how showing both woodland and farmland early and the rest later can be explained by anything other than an euro-centric perspective (Europe has by far the highest dominance of woodland and farmland in combination relative to other landcovers in comparison to any other larger region on Earth).

@kocio-pl
Copy link
Collaborator Author

I'm happy to add more diverse landuses if possible, so if you have some propositions, I will investigate it. At this moment I think there are simply not many of them to be visible on mid zoom levels (that's my reason), but for example natural=sand is what I'm testing now.

@imagico
Copy link
Collaborator

imagico commented Aug 11, 2017

Since i don't understand the whole design idea at these zoom levels i have no specific recommendation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants