-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering farmland earlier on midzoom #2722
Conversation
👍 |
I'm in a middle of system upgrade - HDD is just bad choice when dealing with country/continent/planet database, so I will try to measure it when new SSD take over. |
@rrzefox Could you update your map layer with this patch? And maybe even tell us what is the performance hit? |
For OSM servers low+mid zoom levels (z0-z12) would be no big deal anyway, since they update them only when deploying new release. |
And whenever we are developing on these zoom levels, of course. |
Also the re-creation process already takes multiple hours, that amount shouldn't multiply. |
Single Poland exporting times (compared to master), database on SSD:
Looks like they are roughly the same. |
Romania (click to see unscaled images): See also #2688 (comment) for low zoom rendering with farmlands. |
Even though this has already been merged, I've now added that patch on my server. |
Independent of the question how this fits into the design of these zoom levels - which as indicated i don't get in general so i have not commented - it should be clear that showing wood and farmland earlier than all other landcovers makes the style significantly more euro-centric than it already is. Showing wood/forest earlier than all other landcovers is questionable but defensible considering how distinct and globally widespread woodland is and that it often continuously covers larger areas. But i don't see how showing both woodland and farmland early and the rest later can be explained by anything other than an euro-centric perspective (Europe has by far the highest dominance of woodland and farmland in combination relative to other landcovers in comparison to any other larger region on Earth). |
I'm happy to add more diverse landuses if possible, so if you have some propositions, I will investigate it. At this moment I think there are simply not many of them to be visible on mid zoom levels (that's my reason), but for example natural=sand is what I'm testing now. |
Since i don't understand the whole design idea at these zoom levels i have no specific recommendation. |
Related to #2654.
Start rendering farmlands on z8+ instead of z10+. I don't want to touch lowzoom yet (#2688), but when we start showing forests/woods on midzoom, we can also show the farmlands, because both are very popular and with color fading they enhance the background in a subtle way.
Full Poland extract (click to see unscaled images):
z8
z9 (converted to JPG to fit in the GitHub filesize limit)