Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move amenity=toilets to higher zoom levels #3055

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

kocio-pl
Copy link
Collaborator

@kocio-pl kocio-pl commented Feb 5, 2018

Related to #1745.

This change moves the toilets to higher zoom levels, because in well mapped areas they compete with other amenities like shop or cafe. Also this is rather a short-distance amenity, so lower zoom levels are not relevant here.

The problem is that we don't even know if they are standalone amenities or just a part of some other amenity. So I guess that toilets with access for everyone ("yes") or paid ("customers'" or "destination") are more important and most probably standalone, but status of the rest (including "permissive" and lack of the access tags) is not clear and they are probably less important.

Louvre example (click the images to view full size)):
z17
Before
nzhd7g_9
After
ijkxw4ux

z18
Before
zfvswuzo
After
ncv4xhfa

@matthijsmelissen
Copy link
Collaborator

I don't like this PR, as it punished more specific tagging ('access=yes').

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Feb 6, 2018

I don't understand why do you think this way. What would be your proposition?

The key problem is to make a sane hierarchy and access=yes is higher than some other access=* tags and higher than toilets without access=* tag. This is not a perfect rule to detect standalone toilets vs toilets being a part of some other objects (like cafe, museum, shopping center or an office), but rough approximation.

@mboeringa
Copy link

The key problem is to make a sane hierarchy and access=yes is higher than some other access=* tags and higher than toilets without access=* tag. This is not a perfect rule to detect standalone toilets vs toilets being a part of some other objects (like cafe, museum, shopping center or an office), but rough approximation.

+1. It is senseless to show non-public toilets at lower zoom levels. A toilet part of a facility like a museum, is not a general public toilet, even if it can be accessed by anyone willing to buy a ticket. That is access=customers.

@kocio-pl
Copy link
Collaborator Author

kocio-pl commented Feb 7, 2018

So maybe only amenity=toilets + access=yes should be visible on z18 and all the rest on z19? I was thinking about paid toilets services, but "customer" might also mean "customer of a cafe/office/etc", not "toilet's customer" and we don't like to show them too prominent.

@kocio-pl
Copy link
Collaborator Author

Updated - access=yes should be mostly sane, all the other cases are more suspected about being just the inner part of some other object.

@kocio-pl
Copy link
Collaborator Author

Any more comments/reviews?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants