-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for leisure=track on lines #3443
Conversation
They should be mapped as areas then. We need leisure=track ways rendering for showing them at least as lines in cases where satellite image is too bad to draw an area, so people map them as ways through their middle (I think we shouldn't interpretate their possible landcovering width), and for unusual things like #3436. It also should match water slides rendering, so I'm OK with this width. |
@Tomasz-W, good call. I agree. |
Thanks, this was a long missing feature. |
I've just found that there are no bridge rendering for leisure=track lines, Here is an exemple why it should be added for better readability. https://www.openstreetmap.org/way/327635778 @Adamant36 Could you take care of that? |
I'll look into it. Its also tagged as a summer toboggan. Which is something ive been meaning to work on. I think the track tag is wrong in this just and just so it will render. |
Well, I guess it says to add track to it on the wiki page. I think its a stretch though since summer toboggans aren't racing tracks per say. It also begs the question, if all of the summer toboggans are suppose to tag as tracks, then whats the point in added rendering for them? If there is none because they are covered by track rendering (which personally I dont think they should be) you might want to request the summer toboggan be closed. I feel like the track tagging is worth looking into more though just in case. |
@Tomasz-W, can you open a new for it please so it doesn't get lost and people can discuss it if they want? |
This PR adds rendering for leisure=track on lines. As it is they are currently rendered on areas but not on ways. Closes #2632
https://www.openstreetmap.org/#map=18/39.19833/-122.02187 (location 1)
https://www.openstreetmap.org/#map=18/39.14384/-121.67329 (location 2)
There is also some other related issues in #2632 that it potentially closes, but I wasn't sure which ones. So I can add them later. Also, the line is a little thin and tracks are usually pretty wide. So maybe it could be made wider.