Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (eks sync-core-components): Increase maxEKSBuild #215

Merged

Conversation

ThisGuyCodes
Copy link
Contributor

@ThisGuyCodes ThisGuyCodes commented Nov 21, 2023

Description

Fixes #214

The maximum number of builds (sub-patches?) to search for with eks compnent images was hard coded to 10 (actually 9, since the last one has to error / miss for the code to work), but there are in fact 10 builds of eks/coredns:1.9.3-eksbuild. This doubles the threshold to 20, to reduce the chances of this happening again.

At present any attempt to create / update an EKS cluster using K8s 1.26 will error (see #214).

$ curl https://602401143452.dkr.ecr.us-west-2.amazonaws.com/v2/eks/coredns/manifests/v1.9.3-eksbuild.10 -H "Authorization: Basic $token"
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 739,
         "digest": "sha256:ccd971aef1b9e189ec21a2e70ba93ed6a339ea8be071f28cff6833db833fd742",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 739,
         "digest": "sha256:00905877cf1be0c1440cde988319f5a6fff848dd783a4517db3c848fd7ef9c5c",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      }
   ]
}
  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
    - [ ] Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
    - [ ] Run the relevant tests successfully.

Release Notes

Increase maxEKSBuild to 20, Fixes #214

there are in fact 10 builds of eks/coredns:1.9.3-eksbuild. This doubles the threshold to 20, to reduce the chances of this happening again.
@ThisGuyCodes
Copy link
Contributor Author

I feel #216 is a more permanent solution than this, and it makes performance more consistent across the board. But I acknowledge it's much more complex so I'll leave it to the maintainers to decide.

@ryehowell
Copy link
Contributor

Hi @ThisGuyCodes , we are testing this PR now. Can you confirm what version of kubergrunt you are using just for an apples to apples comparison?

@ThisGuyCodes
Copy link
Contributor Author

I'm using the latest release

@ryehowell
Copy link
Contributor

I'm using the latest release

Ok perfect, thank you for confirming.

@ryehowell ryehowell merged commit 86d0d9c into gruntwork-io:main Nov 23, 2023
2 of 4 checks passed
@ryehowell
Copy link
Contributor

Hi @ThisGuyCodes, as mentioned in #216, this PR has been merged and released. v0.13.1 should address the issue with kubergrunt. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubergrunt eks sync-core-components Error-message. Code: TOO_MANY_EKS_BUILD_TAGS
3 participants