Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (eks sync-core-components): Increase maxEKSBuild, do binary search #216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ThisGuyCodes
Copy link
Contributor

@ThisGuyCodes ThisGuyCodes commented Nov 21, 2023

Description

Fixes #214
Replaces #215

The maximum number of builds (sub-patches?) to search for with eks compnent images was hard coded to 10 (actually 9, since the last one has to error / miss for the code to work), but there are in fact 10 builds of eks/coredns:1.9.3-eksbuild. This massively jumps the threshold to 128, and switches to doing a binary search rather than a forward crawl to keep the request count down.

At present any attempt to create / update an EKS cluster using version 1.24 through 1.26 will error (see #214).

$ curl https://602401143452.dkr.ecr.us-west-2.amazonaws.com/v2/eks/coredns/manifests/v1.9.3-eksbuild.10 -H "Authorization: Basic $token"
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 739,
         "digest": "sha256:ccd971aef1b9e189ec21a2e70ba93ed6a339ea8be071f28cff6833db833fd742",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 739,
         "digest": "sha256:00905877cf1be0c1440cde988319f5a6fff848dd783a4517db3c848fd7ef9c5c",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      }
   ]
}
  • Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
    - [ ] Update the docs.
  • Keep the changes backward compatible where possible.
  • Run the pre-commit checks successfully.
    - [ ] Run the relevant tests successfully.

Release Notes

Find eksbuild's via binary search, Fixes #214

@ThisGuyCodes
Copy link
Contributor Author

I feel this is a more permanent solution than #215, and it makes performance more consistent across the board. But I acknowledge it's much more complex so I'll leave it to the maintainers to decide.

@ryehowell
Copy link
Contributor

Hi @ThisGuyCodes , we are testing this PR now. Can you confirm what version of kubergrunt you are using just for an apples to apples comparison? We'll take a look at both PR's that were opened, but might go with #215 initially. Will follow up either way.

@ThisGuyCodes
Copy link
Contributor Author

I'm using the latest release, v0.13.0

@ryehowell
Copy link
Contributor

Hi @ThisGuyCodes, we got #215 merged and released. v0.13.1 addresses the issue (I just verified). Thanks again for the contribution!

We can keep this PR open if you would like. I plan to circle back to function to update to a more robust solution that is less constrained with the limits and the overall implementation.

@ThisGuyCodes
Copy link
Contributor Author

Happy to keep it open!

There are in fact 10 builds of eks/coredns:1.9.3-eksbuild. This jumps the threshold from 10 to 128, and switches to doing a binary search rather than a forward crawl to keep the request count down.
@ThisGuyCodes ThisGuyCodes force-pushed the bug/too-many-eks-builds-binary-214 branch from 9caad3a to 0309e3b Compare November 27, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubergrunt eks sync-core-components Error-message. Code: TOO_MANY_EKS_BUILD_TAGS
2 participants