🐛 (eks sync-core-components): Increase maxEKSBuild, do binary search #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #214
Replaces #215
The maximum number of builds (sub-patches?) to search for with eks compnent images was hard coded to 10 (actually 9, since the last one has to error / miss for the code to work), but there are in fact 10 builds of eks/coredns:1.9.3-eksbuild. This massively jumps the threshold to 128, and switches to doing a binary search rather than a forward crawl to keep the request count down.
At present any attempt to create / update an EKS cluster using version 1.24 through 1.26 will error (see #214).
feature/new-vpc-endpoints-955
orbug/missing-count-param-434
.- [ ] Update the docs.- [ ] Run the relevant tests successfully.Release Notes
Find eksbuild's via binary search, Fixes #214