-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ Add integration test for Template Controller to check deletion #35
base: main
Are you sure you want to change the base?
Conversation
⬆️ Go test coverage increased from 70.9% to 71.2% compared to 4013642 (1 ignored files)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding a test case!
6f104d2
to
267d525
Compare
// Apply all resources specified by the YAML files in the given directory, dir, as well as all sub-directories | ||
// Ignores paths specified in excludePaths | ||
func applyResourcesFromYAMLInDir(ctx context.Context, dir string, excludePaths []string) { | ||
if excludePaths == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see this the first time, I haven't used the slices
package much, but I think nil
will just work as an empty slice, see: https://go.dev/play/p/o6KpQfftdPf
So hopefully you can remove this if block and it will still work.
No description provided.