Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor controller code #41
base: main
Are you sure you want to change the base?
Refactor controller code #41
Changes from 30 commits
0228de6
28dcabc
412936a
5c1a286
5028c0b
f16a8ae
2cea244
13875bc
b8e52a1
fd8b799
6e1dbf7
5996c64
38ff5be
9f83ada
57adccc
cdfec43
cb3d04a
b772291
daf91d5
24e8500
135cea3
c326f0d
cdea02f
4113333
335094a
7d7a1a7
99ce2cf
502768a
e2fdf40
06b4593
cd3ac7e
6c74a8b
60df66a
40e2efe
182fc3f
b31ed27
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hoping we wouldn't have to query Kubernetes to get templates, we should be able to track them all in memory.
If we do need to query Kubernetes here, can you use the
TemplateAPIGroup
constant and others from thetemplate
package? And avoid hard-coding a namespace--maybe now is the time to makeTemplate.kumquat.guidewire.com
a cluster-scoped CRD instead of namespace-scoped?