Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docker-compose.yml file to use hackforla image instead of jekyll/jekyll:pages #3319

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Update docker-compose.yml file to use hackforla image instead of jekyll/jekyll:pages #3319

merged 1 commit into from
Jun 29, 2022

Conversation

ericvennemeyer
Copy link
Member

Fixes #3068

What changes did you make and why did you make them ?

  • In docker-compose.yml file, changed value of image: key from jekyll/jekyll:pages to hackforlaops/ghpages:latest
  • This fixes the various Jekyll/Ruby errors new volunteers have been experiencing when setting up Docker for the first time, and eliminates the need for the current temp fix (changing image: to jekyll/jekyll:4.2.0)

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Updated a Docker config file in the root of website directory. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b ericvennemeyer-fix-error-docker-compose-up-3068 gh-pages
git pull https://github.com/ericvennemeyer/website.git fix-error-docker-compose-up-3068

@github-actions github-actions bot added Bug Something isn't working Feature: Infrastructure For changes on site technical architecture role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours Complexity: Medium Status: Updated No blockers and update is ready for review labels Jun 27, 2022
@lilyarj lilyarj self-assigned this Jun 28, 2022
@lilyarj
Copy link
Member

lilyarj commented Jun 28, 2022

Availability: 2 hr
ETA: 6/28

@lilyarj lilyarj removed their assignment Jun 28, 2022
@lilyarj lilyarj self-requested a review June 28, 2022 18:32
lilyarj
lilyarj approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@lilyarj lilyarj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

@BeckettOBrien BeckettOBrien self-requested a review June 28, 2022 22:42
@BeckettOBrien
Copy link
Member

Availability: 1 hr
ETA: EOD 6/28

BeckettOBrien
BeckettOBrien approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@BeckettOBrien BeckettOBrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The site works perfectly, and this also fixed my issue with missing ruby gems!

@Wny-Duong Wny-Duong mentioned this pull request Jun 29, 2022
Open
12 tasks
@Wny-Duong Wny-Duong merged commit 4475e17 into hackforla:gh-pages Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilyarj lilyarj lilyarj approved these changes

@BeckettOBrien BeckettOBrien BeckettOBrien approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Complexity: Medium Feature: Infrastructure For changes on site technical architecture role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours Status: Updated No blockers and update is ready for review
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix "no implicit conversion of Hash into Integer" error when running docker-compose up locally
4 participants
@ericvennemeyer @lilyarj @BeckettOBrien @Wny-Duong