refactor: removal of implicit Enabled attribute #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove code to handle missing attributes where they are now part of what composite object produces - use `isPresent` when checking for configured and enabled features
roleyfoley
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent of Change
Description
isPresentwhen checking for configured and enabled featuresMotivation and Context
Part of hamlet-io/engine#1894
How Has This Been Tested?
Local template generation
Not all components have been exercised but expecting the test suite to pick up the less commonly used ones. This will require the prerequisite PR to have been merged,
The bulk of the correction were detected by the extra code in
isPresent()which reports where it has been called fromso makes it straightforward to identify where remediation is required.
Related Changes
Prerequisite PRs:
Dependent PRs:
Consumer Actions: