Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): memory and lb complex configuration #794

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix(ecs): memory and lb complex configuration #794

merged 1 commit into from
Dec 19, 2023

Conversation

roleyfoley
Copy link
Contributor

Intent of Change

  • Bug fix (non-breaking change which fixes an issue)

Description

  • Handle cases where a max memory hasn't been assigned when service level memory and cpu has been allocated to a fargate task
  • Use the lb parent TargetGroupSG when a container is registering to a lb backend

Motivation and Context

Minor bug fixes when working with more complex container environments

How Has This Been Tested?

Related Changes

Prerequisite PRs:

  • None

Dependent PRs:

  • None

Consumer Actions:

  • None

- Handle cases where a max memory hasn't been assigned
when service level memory and cpu has been allocated to a fargate
task
- Use the lb parent TargetGroupSG when a container is registering to
a lb backend
@roleyfoley roleyfoley requested a review from a team December 19, 2023 08:00
@roleyfoley roleyfoley merged commit d2bd67e into hamlet-io:master Dec 19, 2023
1 of 2 checks passed
@roleyfoley roleyfoley deleted the fix/lb-ecs-minor-updates branch December 19, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant