Add Tag register to protocol #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-f-cruz
requested review from
Poofjunior,
glopesdev,
artursilva0 and
filcarv
Closed
Poofjunior
reviewed
Mar 7, 2024
|
This is now implemented on the RP2040 Harp Core: |
3 tasks
|
Merged
glopesdev
approved these changes
Jan 2, 2025
glopesdev
force-pushed
the
17-firmware-git-hash
branch
2 times, most recently
from
7ac8e4b to
7098f25
Compare
glopesdev
force-pushed
the
17-firmware-git-hash
branch
from
7098f25 to
8c05bd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new register to the protocol called
Tag.This new register should be used to optionally keep information regarding a specific tag of a firmware version. A simple use case would be to keep track of a development version of a given minor release.
Motivation
During development it is often the case that intermediate firmware versions are released. These are impossible to track in the firmware as the protocol only specifies a major and minor version. This new register is added to meet this need. Users can use this register to add a "build" or "preview" tag to the firmware, for instance the git commit that generated the release.
Detailed Design
A new register will be added with the following specs:
Name: Tag
Address: 17
Format: U8[8]
Access: Read-only
Design Meetings
See further discussion in the following issues: