Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nomad WebUI should detect if modifiers in addition to Shift are being pressed, and hide the shortcuts #23361

Closed
lattwood opened this issue Jun 17, 2024 · 0 comments · Fixed by #23365
Closed

Nomad WebUI should detect if modifiers in addition to Shift are being pressed, and hide the shortcuts #23361

lattwood opened this issue Jun 17, 2024 · 0 comments · Fixed by #23365
Assignees
@philrenaud
Labels
hcc/jira theme/ui type/enhancement

Comments

@lattwood
Copy link
Contributor

Proposal

Nomad WebUI should detect if modifiers in addition to Shift are being pressed, and hide the shortcuts if so.

Use-cases

It would be nice to take screenshots on MacOS with the default shortcuts, w/o those labels showing up.

Attempted Solutions

I tried adjusting the order in which I held the modifier keys. (ie, CMD->Ctrl->Shift + 4)

No dice.
@philrenaud philrenaud self-assigned this Jun 17, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Nomad UI Jun 17, 2024
@philrenaud philrenaud moved this from Backlog to Todo in Nomad UI Jun 17, 2024
@philrenaud philrenaud mentioned this issue Jun 17, 2024
Merged
@philrenaud philrenaud linked a pull request Jun 17, 2024 that will close this issue
[ui] Dont show keyboard hints when a user is trying to take a screenshot #23365
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Nomad UI Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philrenaud philrenaud

Labels
hcc/jira theme/ui type/enhancement
Projects
Nomad UI
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ui] Dont show keyboard hints when a user is trying to take a screenshot hashicorp/nomad
2 participants
@philrenaud @lattwood