Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Dont show keyboard hints when a user is trying to take a screenshot #23365

Merged
merged 2 commits into from
Jun 18, 2024
Merged

[ui] Dont show keyboard hints when a user is trying to take a screenshot #23365

merged 2 commits into from
Jun 18, 2024

Conversation

philrenaud
Copy link
Contributor

Resolves #23361

How to test

  • Buy a macbook (or pretend)
  • Hold down shift, to see hints. Release and they're gone!
  • Hold down cmd+shift+4 to take a screenshot
  • Note that in holding the command key, the shift key no longer triggers the display of keyboard hints.

@philrenaud philrenaud requested review from angrycub and gulducat June 17, 2024 17:27
@philrenaud philrenaud self-assigned this Jun 17, 2024
@philrenaud philrenaud linked an issue Jun 17, 2024 that may be closed by this pull request
Nomad WebUI should detect if modifiers in addition to Shift are being pressed, and hide the shortcuts #23361
Closed
@philrenaud philrenaud added the backport/1.8.x backport to 1.8.x release line label Jun 17, 2024
gulducat
gulducat approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📸

ui/app/services/keyboard.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 17, 2024 •
edited
Loading

Ember Test Audit comparison

main 71ca80e change
passes 1572 1572 0
failures 0 0 0
flaky 0 0 0
duration 11m 44s 936ms 11m 23s 489ms -21s 447ms

@martisah martisah self-requested a review June 18, 2024 15:13
@philrenaud philrenaud force-pushed the 23361-nomad-webui-should-detect-if-modifiers-in-addition-to-shift-are-being-pressed-and-hide-the-shortcuts branch from 5e3fe1b to 71ca80e Compare June 18, 2024 16:17
@philrenaud philrenaud merged commit 5aad029 into main Jun 18, 2024
15 checks passed
@philrenaud philrenaud deleted the 23361-nomad-webui-should-detect-if-modifiers-in-addition-to-shift-are-being-pressed-and-hide-the-shortcuts branch June 18, 2024 16:37
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Jun 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martisah martisah martisah approved these changes

@gulducat gulducat gulducat approved these changes

@angrycub angrycub Awaiting requested review from angrycub

Assignees

@philrenaud philrenaud

Labels
backport/1.8.x backport to 1.8.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nomad WebUI should detect if modifiers in addition to Shift are being pressed, and hide the shortcuts
3 participants
@philrenaud @gulducat @martisah