Update map-config.adoc #1377
Update map-config.adoc #1377
Conversation
Changed broken link to point to master to avoid a 404
amandalindsay
requested review from
oliverhowell and
Rob-Hazelcast
as code owners
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -23,8 +23,8 @@ ifdef::snapshot[] | |||
| endif::[] | |||
|
|
|||
| ifndef::snapshot[] | |||
| * link:https://github.com/hazelcast/hazelcast/blob/v{full-version}/hazelcast/src/main/resources/hazelcast-full-example.xml[hazelcast-full-example.xml] | |||
| * link:https://github.com/hazelcast/hazelcast/blob/v{full-version}/hazelcast/src/main/resources/hazelcast-full-example.yaml[hazelcast-full-example.yaml] | |||
| * link:https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/resources/hazelcast-full-example.xml[hazelcast-full-example.xml] | |||
There was a problem hiding this comment.
Sorry for interfering, but maybe a better approach would be to introduce a new variable e.g. hazelcast-tag, and use it here?
It seems that we have here a wrong usage of full-version variable. That variable means the version of the documentation but it was used here ad the version of the hazelcast (set in GH tag)
There was a problem hiding this comment.
Sorry for interfering, but maybe a better approach would be to introduce a new variable e.g.
hazelcast-tag, and use it here? It seems that we have here a wrong usage offull-versionvariable. That variable means the version of the documentation but it was used here ad the version of the hazelcast (set in GH tag)
@fantkolja already under discussion here.
There was a problem hiding this comment.
And related PR: #1355
There was a problem hiding this comment.
You are extremely fast :)
Changed broken link to point to master to avoid a 404