Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update map-config.adoc #1377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update map-config.adoc #1377

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/modules/data-structures/pages/map-config.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ ifdef::snapshot[]
endif::[]

ifndef::snapshot[]
* link:https://github.com/hazelcast/hazelcast/blob/v{full-version}/hazelcast/src/main/resources/hazelcast-full-example.xml[hazelcast-full-example.xml]
* link:https://github.com/hazelcast/hazelcast/blob/v{full-version}/hazelcast/src/main/resources/hazelcast-full-example.yaml[hazelcast-full-example.yaml]
* link:https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/resources/hazelcast-full-example.xml[hazelcast-full-example.xml]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for interfering, but maybe a better approach would be to introduce a new variable e.g. hazelcast-tag, and use it here?
It seems that we have here a wrong usage of full-version variable. That variable means the version of the documentation but it was used here ad the version of the hazelcast (set in GH tag)

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for interfering, but maybe a better approach would be to introduce a new variable e.g. hazelcast-tag, and use it here? It seems that we have here a wrong usage of full-version variable. That variable means the version of the documentation but it was used here ad the version of the hazelcast (set in GH tag)

@fantkolja already under discussion here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And related PR: #1355

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are extremely fast :)

* link:https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/resources/hazelcast-full-example.yaml[hazelcast-full-example.yaml]
endif::[]
====

Expand Down Expand Up @@ -112,4 +112,4 @@ You can use wildcards to create standard configurations for your application, th

== Next Steps

For a complete discussion of Hazelcast configuration options and operations, go to the xref:configuration:understanding-configuration.adoc[configuration] section of the documentation.
For a complete discussion of Hazelcast configuration options and operations, go to the xref:configuration:understanding-configuration.adoc[configuration] section of the documentation.
Loading