Upgrade OpenROAD #196
Merged
Upgrade OpenROAD #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuantamHD
reviewed
Oct 3, 2023
dependency_support/org_theopenroadproject/org_theopenroadproject.bzl
Outdated
Show resolved
Hide resolved
hzeller
reviewed
Oct 3, 2023
dependency_support/org_theopenroadproject/org_theopenroadproject.bzl
Outdated
Show resolved
Hide resolved
mithro
force-pushed
the
openroad-upgrade
branch
from
7ee5539 to
0fc7459
Compare
mithro
force-pushed
the
openroad-upgrade
branch
from
0fc7459 to
55e9f2d
Compare
mithro
force-pushed
the
openroad-upgrade
branch
from
55e9f2d to
b236cca
Compare
mithro
force-pushed
the
openroad-upgrade
branch
from
76f672d to
2973ad7
Compare
|
I'm unsure if there is a better way to do the |
|
Seems to be currently failing due to; |
|
The dependency support test is weird it's also failing for Eric. I don't see it defined anywhere though |
mithro
force-pushed
the
openroad-upgrade
branch
from
fb36e5c to
b97a839
Compare
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
This requires; * Updating the `absl` version. * Adding `protobuf` library. * Rework the `eigen` usage. Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
Signed-off-by: Tim 'mithro' Ansell <[email protected]>
mithro
force-pushed
the
openroad-upgrade
branch
from
b97a839 to
1f3a708
Compare
|
LGTM |
QuantamHD
approved these changes
Oct 4, 2023
QuantamHD
reviewed
Oct 4, 2023
Comment on lines
+48
to
+60
| new_git_repository, | ||
| name = "eigen", | ||
| tag = "3.4.0", | ||
| remote = "https://gitlab.com/libeigen/eigen.git", | ||
| build_file_content = """ | ||
| cc_library( | ||
| name = 'eigen3', | ||
| srcs = [], | ||
| includes = ['.'], | ||
| hdrs = glob(['Eigen/**']), | ||
| visibility = ['//visibility:public'], | ||
| ) | ||
| """, |
There was a problem hiding this comment.
We do have an eigen already is that one not compatible with ortools?
There was a problem hiding this comment.
I wasn't able to figure out how to map the ortools dependency to the one we already had.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes;
rules_python, and vendor requirements.bzl #197report_power.bzl. #186Adds
ortools.