Update rules_python, and vendor requirements.bzl
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
So - the tests run and pass locally for me. I'm not sure why the CI is failing, and can't seem to get the actual test log back out... If anyone knows how we can get the test log back out from the BuildBuddy run, that'd be EXTREMELY helpful. |
Merged
mithro
force-pushed
the
update_rules_python
branch
from
2ede644 to
65f9b13
Compare
|
Found the problem - I was using a test that wasn't Bazel 5.4.0 compatible! Fixed. |
mithro
force-pushed
the
update_rules_python
branch
from
141ad27 to
03f9804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rules_pythondependency has gotten out of date. We don't need any of the upgrades here, but since the way pip dependencies are managed has changed, this is blocking anyone using us from upgrading their ownrules_pythondependency.To fix this, upgrade to the latest
rules_pythonrelease, and update how pip dependencies are handled. Follows the recommended best-practices for vendoring the generatedrequirements.bzl.