Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scipy to optional requirements #1140

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Move scipy to optional requirements #1140

merged 4 commits into from
Jul 8, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 29, 2024

Motivation

scipy is used only by the CSRMatrix data type, which is currently rarely used. To reduce the chance of dependency conflicts and reduce the install time, I propose we make scipy an optional requirement.

This is a breaking change since users using the CSRMatrix type will need to install scipy separately.

Merging into new hdmf_4.0 branch.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Does the PR clearly describe the problem and the solution?
  • Have you reviewed our Contributing Guide?
  • Does the PR use "Fix #XXX" notation to tell GitHub to close the relevant issue numbered XXX when the PR is merged?

Copy link

codecov bot commented Jun 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (539ecf4) to head (7942faa).
Report is 1 commits behind head on hdmf_4.0.

Additional details and impacted files
@@             Coverage Diff              @@
##           hdmf_4.0    #1140      +/-   ##
============================================
+ Coverage     88.78%   88.79%   +0.01%     
============================================
  Files            45       45              
  Lines          9778     9790      +12     
  Branches       2777     2779       +2     
============================================
+ Hits           8681     8693      +12     
  Misses          780      780              
  Partials        317      317              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly requested a review from mavaylon1 June 29, 2024 16:48
@mavaylon1 mavaylon1 self-requested a review July 1, 2024 16:11
Copy link
Contributor

@mavaylon1 mavaylon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Coverage

@rly rly changed the base branch from dev to hdmf_4.0 July 7, 2024 22:45
@mavaylon1 mavaylon1 merged commit 1fef7e5 into hdmf_4.0 Jul 8, 2024
29 checks passed
@mavaylon1 mavaylon1 deleted the optional_scipy branch July 8, 2024 04:01
mavaylon1 added a commit that referenced this pull request Jul 8, 2024
@rly rly mentioned this pull request Jan 17, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants