Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSEARCH-4989 Use a different property to skip JQAssistant analysis of some modules #3783

Merged
merged 1 commit into from
Oct 13, 2023
Merged

HSEARCH-4989 Use a different property to skip JQAssistant analysis of some modules #3783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/config/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<description>Hibernate Search common build configuration files</description>

<properties>
<jqassistant.skip>true</jqassistant.skip>
<jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>

<!--
This module generates the rules used in the Checkstyle and ForbiddenAPIs plugins,
Expand Down
2 changes: 1 addition & 1 deletion build/enforcer/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<format.skip>true</format.skip>

<deploy.skip>true</deploy.skip>
<jqassistant.skip>true</jqassistant.skip>
<jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
</properties>

<dependencies>
Expand Down
6 changes: 0 additions & 6 deletions build/reports/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@
<packaging>pom</packaging>

<properties>
<!--
Do NOT skip jqassistant: we want to execute analysis here so as to fail the build if anything is wrong.
Reminder: jqassistant only executes analysis in the last module of the build,
so if we skip it in the last module, it just won't execute analysis... ever.
-->
<jqassistant.skip>false</jqassistant.skip>
<!--
Disable the dependency convergence rule, because the dependencies of various integration tests do not converge
-->
Expand Down
2 changes: 1 addition & 1 deletion integrationtest/v5migrationhelper/engine/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<properties>
<!-- This is based on legacy code and there are plenty of problems that we don't care to fix -->
<jqassistant.skip>true</jqassistant.skip>
<jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
<forbiddenapis.skip>true</forbiddenapis.skip>
<sonar.skip>true</sonar.skip>
</properties>
Expand Down
2 changes: 1 addition & 1 deletion integrationtest/v5migrationhelper/orm/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<properties>
<!-- This is based on legacy code and there are plenty of problems that we don't care to fix -->
<jqassistant.skip>true</jqassistant.skip>
<jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
<forbiddenapis.skip>true</forbiddenapis.skip>
<sonar.skip>true</sonar.skip>

Expand Down
2 changes: 1 addition & 1 deletion util/internal/integrationtest/v5migrationhelper/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

<properties>
<!-- This is based on legacy code and there are plenty of problems that we don't care to fix -->
<jqassistant.skip>true</jqassistant.skip>
<jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
<forbiddenapis.skip>true</forbiddenapis.skip>
<sonar.skip>true</sonar.skip>
</properties>
Expand Down
2 changes: 1 addition & 1 deletion v5migrationhelper/engine/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<java.module.name>org.hibernate.search.v5migrationhelper.engine</java.module.name>

<!-- This is based on legacy code and there are plenty of problems that we don't care to fix -->
<jqassistant.skip>true</jqassistant.skip>
<jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
<forbiddenapis.skip>true</forbiddenapis.skip>
<sonar.skip>true</sonar.skip>
</properties>
Expand Down
2 changes: 1 addition & 1 deletion v5migrationhelper/orm/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
<java.module.name>org.hibernate.search.v5migrationhelper.orm</java.module.name>

<!-- This is based on legacy code and there are plenty of problems that we don't care to fix -->
<jqassistant.skip>true</jqassistant.skip>
<jqassistant.maven.module.skip>true</jqassistant.maven.module.skip>
<forbiddenapis.skip>true</forbiddenapis.skip>
<sonar.skip>true</sonar.skip>
</properties>
Expand Down
Loading