Update calc.py to support srain_piezo

[smuliv]

Add support for binary sensor "Rain State Piezo" (srain_piezo)

pull request (home-assistant/core#127004) to update integration in core already made.

This PR fixes or closes issue: #200 & home-assistant/core#125850

[airhead1234]

Works for me, too. Would be great to see the component updated.

[GSzabados]

@joostlek and @pvizeli, the PR for the Ecowitt integration (home-assistant/core#127004) and this PR and its companion (#203) for aioecowitt should have ended up in the What the Heck Month... All three of them has been submitted and none of them has been reviewed, but the one for HA has been prematurely closed, as waiting for the two to be merged to aioecowitt. All of these sitting as idle ducks without any interaction, but has about 4 issues related to them. And the author mentions them every month in one of the issues. Maybe the libraries should have a notification set up for review as the components has it for HA. #whattheheckmonth

[joostlek]

Yes I recently brought this up and I'm trying to get these PRs merged. Please stay tuned.

[GSzabados]

Cool! Thanks! And please excuse me for the comment above, but I don't understand why positive contributions ends up without any interaction for months.
I just updated my Ecowitt Station recently and seeing all the warnings in HA and started to research any issue. But I only see that positive contributions have been closed and neglected.

[iculookn]

Yes I recently brought this up and I'm trying to get these PRs merged. Please stay tuned.

Is there anything we could help to add this? I can't code, but I'm happy to buy someone a coffee/beer.

[GSzabados]

@iculookn It is not a matter of coffee or beer. It is a matter of poor management. Somebody has submitted a PR 115 days ago, which solves the problem of the error referenced. This is not even a big change, but adding 2 lines to the code to handle the rain sensor, which was implemented in the Ecowitt firmware.

And meanwhile nobody has reviewed the code and merged it, and the promise about being reviewed is 1 month old already...

Even a PR was submitted to HA to fix the issue on the integration side as well, but that has been closed almost immediately because the upstream PR (this one) has not been merged, which is another 3 lines of code to define the new sensor.

As noted before, these things should have been highlighted during the What The Heck Month, where people contribute obvious fixes and not being merged. These mishaps are just forcing people to fork the integration and start to run a custom integration repo, where fixing issues does not take 4 months.

[smuliv]

What can I say... this was my first contribution to Home Assistant because I thought it was only fair to give something back. But the way this is going doesn't really increase my motivation to release future fixes as pull requests.

[GSzabados]

What can I say... this was my first contribution to Home Assistant because I thought it was only fair to give something back. But the way this is going doesn't really increase my motivation to release future fixes as pull requests.

@joostlek, @pvizeli - I hope you are reading this. The PR is waiting here for 115 days.

Yes I recently brought this up and I'm trying to get these PRs merged. Please stay tuned.

This was posted by @joostlek on the 26th of December, basically a month ago.

This PR is only 2 lines to handle the input from the weather station and to suppress the WARNING:

Logger: aioecowitt.server
Source: components/ecowitt/__init__.py:30
First occurred: 18 January 2025 at 09:53:32 (19651 occurrences)
Last logged: 19:46:14

Unhandled sensor type srain_piezo value 1
Unhandled sensor type srain_piezo value 0

[joostlek]

I'm still busy, something at least got merged to ease the pain. Also don't forget that December and January are busy moments for a lot of people.

[GSzabados]

Do you mean this? 84919bd

This PR was complete on the 28th of December, meanwhile @balloob added the PR mentioned above 2 weeks ago.

This whole issue should have been done and dusted by the end of October.