-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update binary_sensor.py for new binary sensor "Rain State Piezo" #127004
Conversation
Add sensor "Rain State Piezo" (srain_piezo). aioecowitt (https://github.com/home-assistant-libs/aioecowitt) has to be updated too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @pvizeli, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This PR is still awaiting the dependency, and the dependency to be bumped in HA. Please recreate it when that has happened as we can't merge this right now |
Add sensor "Rain State Piezo" (srain_piezo).
aioecowitt (https://github.com/home-assistant-libs/aioecowitt) has to be updated too.
Proposed change
Add new binary sensor Rain State Piezo and get rid of the error message:
WARNING (MainThread) [aioecowitt.server] Unhandled sensor type srain_piezo value 0
Type of change
Additional information
aioecowitt (https://github.com/home-assistant-libs/aioecowitt) must to be updated too because of dependency.
PR home-assistant-libs/aioecowitt#202 submitted
PR home-assistant-libs/aioecowitt#203 submitted
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: