Add support for all packages manager and shrink package size #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinroger
commented
Apr 9, 2023
| @@ -5,10 +5,8 @@ | |||
| const request = require("request"), | |||
| path = require("path"), | |||
| tar = require("tar"), | |||
| zlib = require("zlib"), | |||
There was a problem hiding this comment.
Newer version of tar already uses zlib under the hood if the file is a gzipped one
marvinroger
commented
Apr 9, 2023
| @@ -26,47 +24,13 @@ const PLATFORM_MAPPING = { | |||
| freebsd: "freebsd", | |||
| }; | |||
|
|
|||
| function getInstallationPath(callback) { | |||
| // `npm bin` will output the path where binary files should be installed | |||
| exec("npm bin", function (err, stdout, stderr) { | |||
There was a problem hiding this comment.
As stated in the description, this is only npm compatible, it was not compatible with Yarn and pnmp (same thing for npm_config_prefix env var).
4 tasks
…rt for all package managers
marvinroger
commented
Apr 9, 2023
| Here is the magic: You ask to run `go-npm install` after it completes installing your package. This will pull down binaries from Github or Amazon S3 and install in NPM's `bin` directory. Binaries under bin directory are immediately available for use in your Terminal. | ||
|
|
||
| Edit `package.json` file and add the following: | ||
| ``` | ||
| { | ||
| "postinstall": "go-npm install", | ||
| "preuninstall": "go-npm uninstall", | ||
| "preinstall": "go-npm install" |
There was a problem hiding this comment.
The binaries are linked by npm / yarn etc. on install, so the binary has to be present before the installation. preinstall achieves it, whereas postinstall is too late
alexbouchardd
approved these changes
Apr 11, 2023
There was a problem hiding this comment.
Fantastic work @marvinroger. I was in a rush when trying to deploy the CLI to NPM for our console.hookdeck.com release. Very thankful for your time 🙏
|
1.0.6 has been published to NPM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a fix for the hookdeck/hookdeck-cli#44 issue
I basically simplified the code to make it smaller and compatible with all packages managers:
esbuildbuild step which resulted in a whooping 1.62MB file! Thesrc/index.jsfile is already valid JavaScript / Node.js code, so it cas be used as is, which drastically reduces the library footprintnpm binoutput anymore, as this is not needed and was npm-only. It only requires abinfield in thepackage.json, but I'll do a follow-up PR on https://github.com/hookdeck/hookdeck-cliuninstallcommand anymore. The binary is part of thenode_modulesand is not moved in a global solution, so there's no point in cleaning