Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate fmtm-splitter and remove splitting code in fmtm #1037

Merged
merged 30 commits into from
Dec 11, 2023

Conversation

spwoodcock
Copy link
Member

@spwoodcock spwoodcock commented Dec 7, 2023

Fixes #885

Replaced split by square and split by sql query with fmtm-splitter:

  • split_by_square wraps splitBySquare with params.
  • split_by_sql wraps splitBySql with params.
  • split_by_feature is not used, although is supported by fmtm-splitter (if we want to allow the user to provide custom task splits as a geojson).

I also moved the contributed SQL scripts from @ivangayton into the fmtm-splitter repo.

Note

Originally this included a migration to remove the tables project_aoi, ways_line, ways_poly.
I updated fmtm-splitter --> 0.2.4, which includes dropping the tables by default before creation, so the migration is no longer required (removed).

@spwoodcock spwoodcock added enhancement New feature or request priority:critical Blocking current tasks or user workflow frontend Related to frontend code backend Related to backend code labels Dec 7, 2023
@spwoodcock spwoodcock self-assigned this Dec 7, 2023
@github-actions github-actions bot added the devops Related to deployment or configuration label Dec 7, 2023
@spwoodcock spwoodcock merged commit fb3d0d6 into development Dec 11, 2023
6 of 7 checks passed
@spwoodcock spwoodcock deleted the feat/integrate-fmtm-splitter branch December 11, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code devops Related to deployment or configuration enhancement New feature or request frontend Related to frontend code migration Contains a DB migration priority:critical Blocking current tasks or user workflow
Projects
Development

Successfully merging this pull request may close these issues.

Use fmtm-splitter for task splitting
1 participant