Improved: the catalog's product detail page title (#187) #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishqueSharma
changed the title
amansinghbais
approved these changes
Sep 18, 2023
ymaheshwari1
requested changes
Sep 18, 2023
tanishqueSharma
changed the title
ymaheshwari1
approved these changes
Sep 18, 2023
alsoK2maan
suggested changes
Sep 20, 2023
src/i18n/locales/en.json
Outdated
| @@ -151,7 +151,7 @@ | |||
| "preorder items will be released to the warehouse you have selected.": "{count} preorder items will be released to the warehouse you have selected.", | |||
| "preorders will be cancelled. This action cannot be undone.": "{count} preorders will be cancelled. This action cannot be undone.", | |||
| "Products": "Products", | |||
| "Product details": "Product details", | |||
| "Product audit": "Product audit", | |||
| "Product summary": "Product summary", | |||
There was a problem hiding this comment.
We should remove this entry and re-add the '"Product details' entry as we are using it on the product details page.
alsoK2maan
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #187
Short Description and Why It's Useful
Changed the title of the catalog's product detail page from "Product details" to "Product audit".
Screenshots of Visual Changes before/after (If There Are Any)
Before
After
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance