Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved: the catalog's product detail page title (#187) #230

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Improved: the catalog's product detail page title (#187) #230

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5adb814
Improved: Changed the product detail page title(#187)
tanishqueSharma Sep 18, 2023
f950dcb
Improved: Changed the product detail page title (#187)
tanishqueSharma Sep 18, 2023
4270df9
Improved:renamed the catalogs's product detail page title (#187)
tanishqueSharma Sep 18, 2023
3870491
Improved:renamed the catalogs's product detail page title(#187)
tanishqueSharma Sep 18, 2023
2541e9f
revert package-lock.json
tanishqueSharma Sep 18, 2023
eedeed2
Fixed: translations, re-added missing entry 'Product details' (#187)
tanishqueSharma Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@
"preorder items will be released to the warehouse you have selected.": "{count} preorder items will be released to the warehouse you have selected.",
"preorders will be cancelled. This action cannot be undone.": "{count} preorders will be cancelled. This action cannot be undone.",
"Products": "Products",
"Product details": "Product details",
"Product audit": "Product audit",
"Product summary": "Product summary",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove this entry and re-add the '"Product details' entry as we are using it on the product details page.

"Product cannot be pre-sold because it does not have active purchase orders": "Product cannot be pre-sold because it does not have active purchase orders",
"Product has been accepting from against PO #": "Product has been accepting {category}s from {fromDate} against PO #${POID}",
Expand Down
2 changes: 1 addition & 1 deletion src/views/catalog-product-details.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<ion-buttons slot="start">
<ion-back-button default-href="/catalog"></ion-back-button>
</ion-buttons>
<ion-title>{{ $t("Product summary") }}</ion-title>
<ion-title>{{ $t("Product audit") }}</ion-title>
</ion-toolbar>
</ion-header>
<ion-content>
Expand Down