Derek furst/update derived queries #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponents-datasets Derek furst/multiple components datasets
…dexCollectionSupport Karlburke/search api reindex collection support
…sample ancestor to determine whether it was primary or processed to instead rely on the creation_action property of its activity ancestor. Fixed misc instances of <-()-[]<-() throughout
…sample ancestor to determine whether it was primary or processed to instead rely on the creation_action property of its activity ancestor. Fixed misc instances of -()-[]<-() throughout
|
@DerekFurstPitt The query updates handle the "Central Process" and "Lab Process" Activity types. Do we need to exclude the "Multi-Assay Split" type as well for those component datasets? |
I am uncertain. Issue 534 only says lab process and central process, and the example query bill included specifically uses the "ends with process" bit |
|
From Bill:
|
yuanzhou
requested changes
Oct 27, 2023
yuanzhou
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed dataset_is_primary to use creation_action to determine whether a dataset is primary rather than inspecting its distance from the nearest sample ancestor