-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dataset Activity.creation_action to ENTITY.Dataset as creation_action_activity #574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuanzhou instead of adding adding a new attribute would an on_read_trigger
on the existing creation_action
attribute which fills in the value work?
@ChuckKollar If possible I'd like to use the same creation_action
attribute that exists already, but only currently used for POST operations, I think..
@shirey That was my thinking as well reading through this. If we still want this property to remain transient (for datasets) but want it to be returned on a GET request, I think an on-read trigger would suffice and wouldn't necessitate creating another transient property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these changes, this looks good to me.
OK! Great! Thanks for the suggestions and the read over! :-) I'm assuming that the current work satisfies Bill's change request. |
This PR did contain the addition of the following code in src/instance/app.cfg.example URL for talking to Ontology API (default for DEV)Works regardless of the trailing slashONTOLOGY_API_URL = 'https://ontology-api.dev.hubmapconsortium.org' But Joe wanted it removed, so I did. |
… since this service started using UBKG in the .cfg file
Issue #551