Derek furst/make dataset type required #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-dataset-type Added field dataset_types to publications as well as datasets
…hanged data_types to be not required. These changes are for dataset and publication
yuanzhou
requested changes
Jan 11, 2024
There was a problem hiding this comment.
@DerekFurstPitt it was not described explicitly in #589. Once we make data_types optional and dataset_type a required field, the auto generated field Dataset.dataset_title via a read trigger should also be using dataset_type. And there's no need to convert based on the old field.
…ataset property and is autogenerated. Now uses dataset_type instead of data_types and some existing conversions were no longer needed
yuanzhou
approved these changes
Jan 16, 2024
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed dataset types to be required on create (but not update) and changed data_types to be not required. These changes are for dataset and publication