Modified data sankey endpoint. Uses dataset_type rather than data_types. #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Various conversions and mappings no longer required. Also fixed a previous inefficiency which would cause the function to take minutes to run. Now it only takes seconds. This was caused by unecessary calls to ontology. This was done by modifying validate_organ_code to take an optional argument that includes the organ dictionary.
yuanzhou
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified data sankey endpoint. Uses dataset_type rather than data_types. Various conversions and mappings no longer required. Also fixed a previous inefficiency which would cause the function to take minutes to run. Now it only takes seconds. This was caused by unecessary calls to ontology. This was done by modifying validate_organ_code to take an optional argument that includes the organ dictionary.