Dataset sample and donor endpoints #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 5, 2024
ChuckKollar
requested review from
yuanzhou
and removed request for
DerekFurstPitt
yuanzhou
requested changes
Feb 7, 2024
There was a problem hiding this comment.
@ChuckKollar here is the summary of the solution change: hubmapconsortium/ingest-api#411 (comment)
yuanzhou
requested changes
Feb 8, 2024
src/app.py
Outdated
| # If there are zero items in the list associated organs, then there are no associated | ||
| # Organs and a 404 will be returned. | ||
| if len(associated_samples) < 1: | ||
| not_found_error("the dataset does not have any associated organs") |
There was a problem hiding this comment.
Should say "samples" instead of "organs" in the 404 message, also update the comment above
src/app.py
Outdated
| # If there are zero items in the list associated organs, then there are no associated | ||
| # Organs and a 404 will be returned. | ||
| if len(associated_donors) < 1: | ||
| not_found_error("the dataset does not have any associated organs") |
There was a problem hiding this comment.
Fix error message and comment above line to say "donors".
| @@ -670,6 +670,44 @@ def get_associated_organs_from_dataset(neo4j_driver, dataset_uuid): | |||
|
|
|||
| return results | |||
|
|
|||
| def get_associated_samples_from_dataset(neo4j_driver, dataset_uuid): | |||
There was a problem hiding this comment.
Please add the comment block above the function declaration
|
|
||
| return results | ||
|
|
||
| def get_associated_donors_from_dataset(neo4j_driver, dataset_uuid): |
There was a problem hiding this comment.
Please add the comment block above the function declaration
yuanzhou
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Endpoint to return 'samples', 'organs', and 'donors' uuids of dataset id given.
Issue: #604