Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derek furst/generalize sublcassing #623

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Conversation

yuanzhou
Copy link
Member

@yuanzhou yuanzhou commented Feb 9, 2024

Following merged PR #616 #624 for TEST

DerekFurstPitt and others added 4 commits February 7, 2024 14:44
…w only

includes properties that are different than datasets. The rest it inherits
using yaml anchors and aliases. In schema_manager generate_triggered_data,
we now need to remove the null values from properties that are None.
nones are removed that should be, not just those with trigger methods
@yuanzhou yuanzhou marked this pull request as ready for review February 14, 2024 18:48
@yuanzhou yuanzhou merged commit 40da2f4 into main Feb 14, 2024
2 checks passed
@yuanzhou yuanzhou deleted the Derek-Furst/generalize-sublcassing branch February 16, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants