Initial commit of changes supporting Multi-Assay Dataset tracking #639
Conversation
There was a problem hiding this comment.
@kburke, we'll need to make two additional changes:
-
Check the existence of the provided uuid from each property upfront. Can be handled in a similar fashion: https://github.com/hubmapconsortium/entity-api/blob/karlburke/AddAttribsToTrackMultiAssayComponents/src/app.py#L1243-L1264
-
These two new Dataset properties should not be available to Publication. Because Publication is considered as a subclass of Dataset, they'll be inherited by Publication unless you set them to
nullin the yaml. Example: https://github.com/hubmapconsortium/entity-api/blob/karlburke/AddAttribsToTrackMultiAssayComponents/src/schema/provenance_schema.yaml#L633
…e of Multi-Assay attributes, and verify attribute UUIDs exist, as a minimum.
src/schema/schema_validators.py
Outdated
| f" {new_data_dict['new_associated_multi_assay_uuid']}" | ||
| f" does not exist.") | ||
| if 'superseded_associated_processed_component_uuids' in new_data_dict: | ||
| proposedComponentsList = schema_manager.convert_str_literal(new_data_dict['superseded_associated_processed_component_uuids']) |
There was a problem hiding this comment.
We don't need to use convert_str_literal() here since the uuids list is already a Python list from converted from request JSON payload.
…thon data structures converted from request JSON.
Initial commit of changes supporting Multi-Assay Dataset tracking for entity-api #635. Added superseded_associated_processed_component_uuids and new_associated_multi_assay_uuid attributes to Datasets.